Skip to content

fix(signature): ag2 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oscar-wos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(signature): ag2 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FallenMovementUnlocker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using SwiftlyS2.Shared.Plugins;
namespace FallenMovementUnlocker;

[PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.0", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")]
[PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.1", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")]
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PluginMetadata version was bumped to 1.0.1, but the project’s AssemblyVersion (src/FallenMovementUnlocker.csproj) and version.txt are still 1.0.0. If releases/packaging rely on those values, this mismatch can cause confusing version reporting; consider updating them in sync (or document why they intentionally differ).

Suggested change
[PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.1", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")]
[PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.0", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")]

Copilot uses AI. Check for mistakes.
public sealed class FallenMovementUnlocker(ISwiftlyCore core) : BasePlugin(core)
{
public override void Load(bool hotReload)
Expand Down
2 changes: 1 addition & 1 deletion src/resources/gamedata/patches.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"MovementUnlocker": {
"signature": "MovementUnlocker",
"windows": "E9 B0 00 00 00 90",
"windows": "E9 B1 00 00 00 90",
"linux": "90 90 90 90 90 90"
}
}
4 changes: 2 additions & 2 deletions src/resources/gamedata/signatures.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"MovementUnlocker": {
"lib": "server",
"windows": "0F 86 AF ? ? ? 0F 57 C0 0F 2E C2",
"linux": "0F 87 ? ? ? ? F3 0F 10 3D ? ? ? ? F3 0F 11 BD ? ? ? ? 48 89 DE"
"windows": "0F 86 B0 ? ? ? 0F 57 C0 0F 2E C2",
"linux": "0F 87 ? ? ? ? F3 0F 10 35 ? ? ? ? F3 0F 11 B5"
}
}
Loading