Conversation
…ng current team members
…mber role handling
|
@SouriRishik is attempting to deploy a commit to the fallendeity's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
why here lol this is an unmaintained upstream just for legacy purposes, i should prolly archive this repo |
|
my contributions aren't seen since it is a forked repo, so by submitting a PR at aleast..... |
| export function Sponsors(): React.JSX.Element { | ||
| const sponsors = useSponsors(); | ||
| const player = useRef(Autoplay({ delay: 2000, stopOnInteraction: true })); | ||
| const { resolvedTheme } = useTheme(); |
There was a problem hiding this comment.
why not make an abstracted component which instead of a map relies on say a suffix -light or -dark with a global fallback (you could have x-light.jpg and x-dark.jpg), the map approach seems rigid, also similarly maybe instead of the mounted var just use the global fallback for rendering? regardless the overrides should go in constants.ts or smn
There was a problem hiding this comment.
what's wrong with the current one? like it works perfectly since sanity one has the dark verision pictures and the one in the workspace has the light one, i can just do it like what i am doing right now by mapping it
| className={cn( | ||
| "flex h-12 w-full items-center justify-center rounded-full p-0 font-normal xs:w-12 xs:border", | ||
| !date && "text-muted-foreground", | ||
| resolvedTheme === "light" ? "xs:wave" : "" |
There was a problem hiding this comment.
any reason for this effect being only in light?
There was a problem hiding this comment.
nah i removed the component, it was just while testing i added that
| const selectedYear = date?.getFullYear(); | ||
|
|
||
| function handleSelect(year: number): void { | ||
| const base = date ?? new Date(); |
| if (!Array.isArray(alumniYears) || alumniYears.length === 0) return; | ||
| if (typeof window === "undefined") return; | ||
| const nav = | ||
| typeof window.performance.getEntriesByType === "function" |
There was a problem hiding this comment.
looks to logic heavy and seems to rely on the browser specific api making it kinda brittle?
There was a problem hiding this comment.
I think it looks fine itself?
Using Performance API to detect if the user did a hard refresh/reload shouldn't make it brittle imo
| if (!date) return; | ||
| const y = date.getFullYear(); | ||
| const yearMembers = members[String(y)]; | ||
| if (Array.isArray(yearMembers) && y <= new Date().getFullYear() - 1) { |
| ), | ||
| [details, subsystem] | ||
| ); | ||
| const members = useMemo(() => { |
There was a problem hiding this comment.
create a helper function for filtering? this might get tedious with more roles
There was a problem hiding this comment.
ahhh i mean there won't be more roles so i thought this was fine. This was just for the Senior member thing, anyways it was just for sorting them in order
so i thought no need a function for it
… enhanced work details display
2 participants
-> alumni page is introduced
-> update contents in the home page
-> update to sponsors for better visibilty of sponsers in different themes
-> update in Navbar