Add download of embed PDF attachment#61
Open
JellyKuo wants to merge 3 commits intoFallingLights:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teachable courses could contain PDF with class
lecture-attachment-type-pdf_embedThis PR searches for PDF embeds with download link, and triggers download with WebDriver + file polling.
Additionally, the file polling download logic previously in
download_video_fileis moved out to a separate functionwebdriver_download. The new function accepts these parameters:output_path: The path to which the download file is emitted. This is passed to CDP commandPage.setDownloadBehavior.downloadPathtrigger_download: A lambda function to actually trigger the download. Eg.lambda: element.click()timeout = -1: Optional timeout for file polling as there is no method to retrieve the download progress. Default is -1 (No timeout).This should close #38. But I'm not sure about MP3 attachments as I do not have courses that use this. This PR should address PDFs though.