Open
Conversation
demiankatz
requested changes
Sep 8, 2025
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
I see that the build is failing here because the PHP version has been raised to 8.2, but the GitHub Actions matrix is still testing with PHP 8.1. Can you adjust https://github.com/FalveyLibraryTechnology/VuOwma/blob/dev/.github/workflows/ci.yaml#L11-L18 so that we use 8.2, 8.3 and 8.4 in place of 8.1, 8.2 and 8.3? I suspect that will move things forward at least!
demiankatz
requested changes
Sep 16, 2025
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Now that #15 is merged, can you merge dev back into this branch and see if the build passes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.