new RelationshipType's and FactType's for Associations#76
Open
new RelationshipType's and FactType's for Associations#76
Conversation
Contributor
Author
|
#76 I’m sure there will need to be some updates. I added the 2 new ones Todd P had talked about Friend and Relative, but not sure about the actual TF naming. |
dnash21e
commented
Dec 9, 2020
| testType("http://familysearch.org/v1/TribeName", FamilySearchFactType.TribeName); | ||
|
|
||
| // association fact types | ||
| //testType("http://familysearch.org/v1/Apprenticeship", FamilySearchFactType.Apprenticeship); // exists as a core Gedcomx FactType |
Contributor
Author
There was a problem hiding this comment.
One issue here is for TF the Apprenticeship fact type is in the familysearch namespace
But it is in core Gedcomx and I believe that will use http://gedcomx.org/Apprenticeship
stoicflame
approved these changes
Dec 9, 2020
Member
stoicflame
left a comment
stoicflame
left a comment
There was a problem hiding this comment.
I think I'm good with the changes as proposed here.
When this gets merged, I'd like to update the spec for at least the new relationship types.
dnash21e
force-pushed
the
AssociationRelationships
branch
4 times, most recently
from
7ee7b0d to
a59705c
Compare
dnash21e
force-pushed
the
AssociationRelationships
branch
from
a59705c to
d34d86c
Compare
dnash21e
force-pushed
the
AssociationRelationships
branch
from
d34d86c to
4504611
Compare
dnash21e
force-pushed
the
AssociationRelationships
branch
from
4504611 to
cbaf459
Compare
dnash21e
force-pushed
the
AssociationRelationships
branch
from
cbaf459 to
1c1acf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.