Skip to content

Fix link anim export#676

Merged
Dragorn421 merged 2 commits intoFast-64:mainfrom
Dragorn421:fix_link_anim_export
Mar 3, 2026
Merged

Fix link anim export#676
Dragorn421 merged 2 commits intoFast-64:mainfrom
Dragorn421:fix_link_anim_export

Conversation

@Dragorn421
Copy link
Contributor

There were several bugs and missing features:

  1. the folderName was still being checked even though isLink=True means it doesn't play a role (the UI doesnt display it)
  2. ootGetObjectPath was called for isLink=True with the folderName which again isn't relevant for link anims exports
  3. assets/misc/link_animetion/ and assets/objects/gameplay_keep/ were not being created if missing (which is the case post "new" assets system)
  4. link_animetion.c and gameplay_keep.c were being created in the case of "new" assets system tm, when the proper thing to do is to just export the .c to assets/ and link the relevant .o files in the spec, which is now done in this PR

@Dragorn421 Dragorn421 added bug Something isn't working oot Has to do with the Ocarina of Time 64 side labels Feb 28, 2026
Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work properly

Image

so I guess the order doesn't matter? that's good to know 💪
I'm not particularily fan of this filename format but I can live with it, also I just realised the custom filename option isn't working for some reasons

@Dragorn421
Copy link
Contributor Author

yeah the spec commands can be in any order
I just put the new includes last because it made processing the spec much much easier, and I figured anyone relying on fast64 to autoupdate the spec wouldnt care anyway

the filename format is not changed in this pr, that's what it was before
I agree it leaves room for improvement (but out of scope)

@Dragorn421
Copy link
Contributor Author

I ended up hiding the "custom filename" option (if exporting link anims), because link anims are made of two sets of two files, so specifying a single custom filename can't work

@Yanis002 Yanis002 added the merge soon Will be merged in a few days at most if nothing else comes up label Mar 1, 2026
@Dragorn421 Dragorn421 merged commit 23424ed into Fast-64:main Mar 3, 2026
1 check passed
@Dragorn421 Dragorn421 deleted the fix_link_anim_export branch March 3, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants