Skip to content

refactor some test code#6087

Merged
cowtowncoder merged 5 commits into
FasterXML:3.xfrom
pjfanning:test-refactor
Jul 10, 2026
Merged

refactor some test code#6087
cowtowncoder merged 5 commits into
FasterXML:3.xfrom
pjfanning:test-refactor

Conversation

@pjfanning

@pjfanning pjfanning commented Jul 10, 2026

Copy link
Copy Markdown
Member
  • another batch of changes
  • assertEquals with params in wrong order
  • tidier string conversions

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 81.71% 📈 +0.000%
Branches branches 75.23% 📈 +0.000%

Coverage data generated from JaCoCo test results

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 81.71% 📈 +0.000%
Branches branches 75.24% 📈 +0.010%

Coverage data generated from JaCoCo test results

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 81.71% 📈 +0.000%
Branches branches 75.22% 📉 -0.010%

Coverage data generated from JaCoCo test results

cowtowncoder
cowtowncoder reviewed Jul 10, 2026
View reviewed changes
Comment thread src/test/java/tools/jackson/databind/deser/creators/TestCreators2.java Outdated
} catch (IOException e) {
throw new RuntimeException(e);
}
return str.getBytes(StandardCharsets.UTF_8);

@cowtowncoder cowtowncoder Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use helper "utf8Bytes()" (will change)

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 81.71% 📈 +0.000%
Branches branches 75.22% 📉 -0.010%

Coverage data generated from JaCoCo test results

cowtowncoder
cowtowncoder approved these changes Jul 10, 2026
View reviewed changes

@cowtowncoder cowtowncoder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cowtowncoder cowtowncoder merged commit b0ca970 into FasterXML:3.x Jul 10, 2026
4 checks passed
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 81.71% 📈 +0.000%
Branches branches 75.22% 📉 -0.010%

Coverage data generated from JaCoCo test results

@pjfanning pjfanning mentioned this pull request Jul 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pjfanning @cowtowncoder