feat(frontend): block writes on network mismatch in metadata + admin forms#906
Merged
Conversation
…forms Extend useNetworkGuard (already on create/mint/burn) to the remaining write forms so all on-chain writes are hard-blocked when Freighter's network differs from the app's, not just warned by the banner: - MetadataForm (set_metadata via /metadata) - SetMetadataForm (set_metadata via TokenDetail) - AdminPanel (update_fees and other admin ops) Update MetadataForm/AdminPanel tests to supply mismatch in the useNetwork mock (AdminPanel now consumes NetworkContext via the guard).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the network-mismatch safety work.
useNetworkGuardwas wired into create/mint/burn; this extends it to the remaining on-chain write forms so all writes are hard-blocked (submit disabled + reason) when Freighter's network differs from the app's — not just warned by the globalNetworkMismatchBanner.Changes
MetadataForm(set_metadatavia/metadata) — guard submitSetMetadataForm(set_metadatavia TokenDetail) — guard submitAdminPanel(update_fees+ other admin ops) — guard submitmismatchto theuseNetworkmock inMetadataForm.test; add auseNetworkmock toAdminPanel.test(AdminPanel now consumesNetworkContextvia the guard).AdminPanel.integration.testdoesn't render the component, so it's unaffected.Verification
typecheck ✓ · lint ✓ · format ✓ · 452 tests ✓ · build ✓