Skip to content

Improve axis and crosshair overlays - #49

Merged
Federicocervelli merged 3 commits into
developmentfrom
fix/axis-crosshair-overlays
May 28, 2026
Merged

Improve axis and crosshair overlays#49
Federicocervelli merged 3 commits into
developmentfrom
fix/axis-crosshair-overlays

Conversation

@Federicocervelli

Copy link
Copy Markdown
Owner

Summary

  • keep X/Y axis endpoint labels readable and hide overlapping tick labels
  • add generic X-range metadata for picked samples
  • let crosshair highlights render X-range rectangles by default and expose a custom renderHighlight hook
  • add crosshair labelPlacement option

Tests

  • bun run typecheck
  • bun run build
  • bun run docs:readme
  • bun run test:generated-docs
  • bun run test:visual

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b1a9610cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/types.ts
Comment on lines +72 to +74
/** Dataset whose sample X values represent intervals rather than points. */
export interface XRangeDataset extends Dataset {
getXRange(index: number): XRange | null;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Export the new X-range dataset types

These new interfaces are the only named contract for datasets that want crosshair/tooltip interval highlighting, but they are not re-exported from either src/index.ts or src/core/index.ts, so package consumers cannot import XRangeDataset/XRange through the public blazeplot or blazeplot/core entry points despite the runtime now checking for getXRange(). This makes the new extension point effectively internal for TypeScript users; add these types to the public barrels alongside the other dataset capability interfaces.

Useful? React with 👍 / 👎.

@Federicocervelli
Federicocervelli merged commit 18db445 into development May 28, 2026
1 check failed
@Federicocervelli
Federicocervelli deleted the fix/axis-crosshair-overlays branch May 28, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant