Improve axis and crosshair overlays - #49
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b1a9610cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** Dataset whose sample X values represent intervals rather than points. */ | ||
| export interface XRangeDataset extends Dataset { | ||
| getXRange(index: number): XRange | null; |
There was a problem hiding this comment.
Export the new X-range dataset types
These new interfaces are the only named contract for datasets that want crosshair/tooltip interval highlighting, but they are not re-exported from either src/index.ts or src/core/index.ts, so package consumers cannot import XRangeDataset/XRange through the public blazeplot or blazeplot/core entry points despite the runtime now checking for getXRange(). This makes the new extension point effectively internal for TypeScript users; add these types to the public barrels alongside the other dataset capability interfaces.
Useful? React with 👍 / 👎.
Summary
Tests