fix: missing exclude patterns + GPG signing crash#4
Merged
Conversation
- Add backups, cache, chrome, daemon, session-env, temp dirs to excludes - Add mcp-needs-auth-cache.json, scheduled_tasks.lock, .last-cleanup, *.lock to excludes - Fix git commit to pass -c commit.gpgsign=false so push works on machines with global GPG signing enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two bugs causing real pain:
1. GPG signing crash on push
git.Commit()calledgit commit -m ...without overriding GPG signing. Any machine withcommit.gpgsign=trueglobally (common on dev machines) crashes every push withgpg failed to sign the data.2. Missing exclude patterns
Several directories/files were never excluded, causing them to be committed to the sync repo on every push:
backups/.claude.jsonsnapshots by CC — redundant withclaude.json.agealready syncedcache/chrome/daemon/session-env/temp/mcp-needs-auth-cache.jsonscheduled_tasks.lock.last-cleanup*.locktasks/**/.lock)Fix
internal/config/config.go: Add missing patterns toDefaultExcludePatternsinternal/git/git.go: Pass-c commit.gpgsign=falseinCommit()so it works regardless of global git configTest