Close qBitrr parity gaps: category workers, MatchSubcategories, retries#280
Merged
Conversation
2 tasks
Implement gap-report items from qBitrr 5.12.3 comparison: - Add CategoryOwnershipHelper and MatchSubcategories config (qBit + per-Arr) - Add QBitCategoryWorkerManager for qBit-only ManagedCategories (PlaceHolderArr parity) - Wire ApplySeedingLimitsAsync, RemoveCompletedTorrentsAsync, import path tracking - Add post-import empty-folder cleanup via ImportPathTracker - Auto-create qBittorrent categories on all instances (QBitCategoryEnsureService) - Add Polly HTTP retries for Arr/qBit clients (HttpRetryHelper) - Enforce ProfileSwitchRetryAttempts in QualityProfileSwitcherService - Add PeriodicWalCheckpointService (5-minute interval on Host) - Fix DatabaseHealthService.RepairAsync using SQLite backup API - Add DatabaseRetryExtensions for transient SQLite errors - Restart Arr workers on config reload (full/multi_arr/single_arr) - Register ConfigReloader on Host; pre-create tracker tags at worker start - Add CategoryOwnershipHelperTests; update full-parity-matrix.md Co-authored-by: Feramance <Feramance@users.noreply.github.com>
for more information, see https://pre-commit.ci
- Add MatchSubcategories checkbox to qBit and Arr config editor fields - Update torrent handling summary text for prefix vs exact category matching - Refactor QBitCategoryWorkerManager with proper worker lifecycle (restart/sync) - Add DatabaseRestartCoordinator and watchdog for coordinated worker recovery - Wire SaveChangesWithRetryAsync into high-traffic DB write paths - Register coordinator in Host and Workers DI Co-authored-by: Feramance <Feramance@users.noreply.github.com>
for more information, see https://pre-commit.ci
- Expand docs/assets/openapi.json to 72 paths (all 66 qBitrr paths + 6 extensions) - Add scripts/generate-openapi-from-qbitrr.py and strengthen check-openapi-drift.sh - Serve curated spec at /api|web/openapi.json; Swagger aliases at /api|web/docs - Implement Lidarr artists missing/reason query param filters - Mark db_lock.py as intentional-divergence; close parity matrix (no partial rows) Co-authored-by: Feramance <Feramance@users.noreply.github.com>
for more information, see https://pre-commit.ci
…er rebase Co-authored-by: Feramance <Feramance@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/qbitrr-parity-gaps-5644
branch
from
7fc0e61 to
e0bf9fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the functional gaps identified in the qBitrr vs Torrentarr comparison report (baseline: qBitrr 5.12.3).
Critical
MatchSubcategories— config key on[qBit]and per-Arr sections;CategoryOwnershipHelperresolves torrent ownership;TorrentProcessorgathers torrents with prefix matching when enabledManagedCategories— newQBitCategoryWorkerManagerruns full torrent lifecycle for categories not owned by an Arr instance (PlaceHolderArr / qBitCategoryManager parity)High / medium
ApplySeedingLimitsAsyncwired inTorrentProcessorpre-stepQBitCategoryEnsureServiceon worker startupImportPathTracker/sent_to_scan) + empty-folder cleanup after processingHttpRetryHelper)full/multi_arr/single_arrreload typesProfileSwitchRetryAttemptsenforced inQualityProfileSwitcherServicePeriodicWalCheckpointService)RemoveCompletedTorrentsAsynccalled from Host torrent processing pathDatabaseHealthService.RepairAsyncfixed using SQLite backup APIDatabaseRetryExtensionsfor transient SQLite save retriesDocs / tests
docs/parity/full-parity-matrix.mdCategoryOwnershipHelperTestsRemaining intentional / partial items
webui.pyrow →partial)repair_database_targeted.pyport (documented intentional divergence)db_lock.py→partial)Test plan
dotnet builddotnet test --filter "Category!=Live"— 764 passed (172 Core + 396 Infrastructure + 196 Host)