This repository was archived by the owner on Jun 19, 2026. It is now read-only.
Backend cleanup stepwise#53
Merged
Merged
Conversation
| } | ||
| decl, err := llvmExternDecl(state, fn) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
collectModuleExternDecls now propagates errors from llvmExternDecl. llvmExternDecl can fail when it can't map an extern's return type to an LLVM type (e.g., missing layout / unsupported type), but the previous inlined logic here explicitly fell back to declaring the return type as ptr rather than failing the whole lowering pass. Consider preserving that behavior by handling llvmExternDecl errors with a safe fallback (or updating llvmExternDecl to never error and instead return a ptr/void declaration).
Suggested change
| return nil, err | |
| decl = fmt.Sprintf("declare ptr @%s(...)", sym) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.