Conversation
kb05
requested changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PLATFORM-5905
💡 Context
When Pypendency fails to load a module with an AttributeError, it assumes that it was because the DI file didn’t have a load() method. This isn’t always the case. For example, this code:
Would raise an exception like this one:
When the problem is really that the method
appenddoesn't exist in numbers.📖 Summary
This PR improves the error handling mechanism by raising the unknown
AttributeErrorin case it isn't caused by a missingloadfunction⚡️Performance Considerations
Negligible. Adds a string check when the module loading fails.
🧪 How should this be manually tested?
src/pypendencyfolder and paste it thesrc/folder of a project that uses Pypendency. This will be enough for "patching" itloadmethod:AttributeErrorpointing at theappend(), instead of mistakenly saying that theload()function is missing