Skip to content

BDE-2483 - Typing change of tags mapping #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LynxEko merged 1 commit into from
Jun 4, 2025
Merged

BDE-2483 - Typing change of tags mapping #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pypendency/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def __init__(self, definitions: List[Definition]):
definition.identifier: definition
for definition in definitions
}
self._tags_mapping: Dict[Tag, List[str]] = {}
self._tags_mapping: Dict[Tag, Set[str]] = {}
Copy link
Copy Markdown
Contributor

@jorgemo-fever jorgemo-fever Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are modifying this, I think that we can also use the built-in types (dict instead of Dict, set instead of Set) to avoid adding an unneeded dependency. WDYT?

Copy link
Copy Markdown
Contributor Author

@LynxEko LynxEko Jun 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love this, however the package still targets python 3.8, and it does not have the built-in types 😢

Copy link
Copy Markdown
Contributor

@andrsdt andrsdt Jun 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny clarification: Built-in types are supported (like set), but they're not subscriptable (like set[str]).
Anyway, as you say, we can't use it here 🙁 we will drop support for 3.8 soon™ 🔥


def resolve(self) -> None:
if self.is_resolved():
Expand Down