refactor(types): tighten up type safety#28
Merged
Fevol merged 8 commits intoFevol:mainfrom Apr 6, 2026
Merged
Conversation
- Replace `any` with `unknown` and proper type guards in deepMerge and deepDiff functions - Add type predicate `isObject` for better type narrowing - Fix virtual module type generation to reference TypeScript types instead of JSON.stringify - Update virtual.d.ts to use FullStarlightSiteGraphConfig instead of StarlightSiteGraphConfig - Improve D3 force simulation type safety with proper generic parameters - Add type-safe narrowing in graph-component.ts for diff results - Add DiffResult and DiffValue types for better type safety
refactor: use enums instead of literal unions for string literals refactor: define all zod defaults values in default value config
feat: make object diffing typesafe refactor: rename deepMerge to mergeDefaults
Fevol
force-pushed
the
fix/type-safety-improvements
branch
from
97f8c5a to
bc43f49
Compare
Owner
|
Thanks for the PR! I have added some commits to the PR to make the functions more type-safe, and refactored the code to make it a bit cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced a bunch of
anytypes with proper typing:Makes the IDE happier and catches more bugs at compile time.