fix(color): add Dark Reader compatibility with robust color parsing#34
Closed
fix(color): add Dark Reader compatibility with robust color parsing#34
Conversation
Resolves issue #12 where Dark Reader extension caused graph rendering failures. Changes: - Add Dark Reader detection via DOM attributes and meta tags - Implement color value sanitization to handle invalid formats - Remove !important flags and reject nested var() references - Add comprehensive fallback colors for each color type - Enhance error logging with context-aware messages - Provide graceful degradation when colors cannot be parsed The graph now renders reliably with Dark Reader active, using fallback colors when the extension corrupts CSS variable values. Users see an informative console message when Dark Reader is detected.
Owner
Author
|
I am closing this PR, as I don't feel like this solves the issue in a satisfying way; and it has likely been solved already (I cannot reproduce it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked commit from #26, authored by @rsp2k.
Original commit message:
Resolves issue #12 where Dark Reader extension caused graph rendering failures.
Changes:
The graph now renders reliably with Dark Reader active, using fallback colors when the extension corrupts CSS variable values. Users see an informative console message when Dark Reader is detected.