Skip to content

fix(ConfidentialETH): use safe staticcall in _cappedDecimals to avoid revert on non-standard WETH #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amathxbt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ConfidentialETH): use safe staticcall in _cappedDecimals to avoid revert on non-standard WETH #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/hardhat/contracts/ConfidentialETH.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ contract ConfidentialETH is FHERC20NativeWrapperUpgradeable, OwnableUpgradeable,
}

function _cappedDecimals(address token) private view returns (uint8) {
uint8 d = IERC20Metadata(token).decimals();
// Use a low-level staticcall so that non-standard WETH implementations
// that revert or omit decimals() do not brick initialization.
// Falls back to 18 (the ERC-20 default) on failure, matching the
// behaviour of ConfidentialERC20._cappedDecimals.
(bool ok, bytes memory data) = token.staticcall(abi.encodeCall(IERC20Metadata.decimals, ()));
uint8 d = (ok && data.length == 32) ? abi.decode(data, (uint8)) : 18;
return d > 6 ? 6 : d;
}

Expand Down