Conversation
Member
|
Had to make some changes to get this working on windows and wsl2 linux. Main thing is that everywhere that was using absolute_url is now using relative_url. Idk why with docker absolute_url was causing Jekyll to build with incorrect paths to the react build files but with just npm run watch everything worked fine. Anyway this seemed to fix that issue. Also added the livereload port to docker-compose.yml to get it working. @JMuff22 @TheKharleeci if you have time at somepoint could you test that this still works on mac 👍 If it still works this should be ready to merge |
Collaborator
Author
|
Tested that it works on mac as well. Merging.... |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A docker environment would be nice for localy development without installing
asdf,rubyandnode. You can run the local environment with fewer commands. Here is the current version. It would be good to also test on Windows and Linux.