Skip to content

Update CODEOWNERS#150

Open
adgad wants to merge 2 commits intomainfrom
codeowner-changes
Open

Update CODEOWNERS#150
adgad wants to merge 2 commits intomainfrom
codeowner-changes

Conversation

@adgad
Copy link
Collaborator

@adgad adgad commented Feb 5, 2026

From a Slack convo - this change hopes to give greater clarity and expectations over ownership and PR reviews for the repo.
The rationale:

  • Spark as the overarching owner: the spark team has probably been closest to the setup of the spec and repo, build processes. And it's helpful to have a single team to have accountability over the future direction.
  • Content-Team owns the Go stuff (is *.go enough? or should it be something wider, like the folder?
  • SPEC.md and package.json (because of version bumps) are co-owned by Spark, Content and Storytelling

(didn't really know what to do with /tests - hopefully this is a good starting point that we can build on)

@adgad adgad requested review from a team as code owners February 5, 2026 17:13
Comment on lines 7 to 9
# Shared ownership for SPEC and package.json (for version bumps)
SPEC.md @Financial-Times/content-team @Financial-Times/spark-team @Financial-Times/storytelling
package.json @Financial-Times/content-team @Financial-Times/spark-team @Financial-Times/storytelling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: as you know, your father, the king @Financial-Times/r13n was the API Rationalisation team; its ownership of cp-content-pipeline was subsumed by @Financial-Times/platforms. it's been rare that we've had a hand in work on content-tree itself but i feel like it's not unthinkable for us to be involved in reviewing things (i'm thinking of things like versioned components or potentially moving some of the model/strategy code into this repo)? 🤷🏻‍♀️

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, not at all!

I will add to you to the shared list, then future things like models we can cross when we get there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added README.md to that shared list, as I imagine that will encompass any significant changes as well

Copy link
Contributor

@andy-little andy-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a big improvement to me :)

@todor-videv1
Copy link

todor-videv1 commented Feb 10, 2026

  • go.sum
  • go.mod
  • content_tree.go
  • the libraries folder currently has only go code inside of it

These are the files/folders we should own I think.

EDIT: Ah actually no, the to-string transformer has TS/JS code. @adgad is this code needed, should we delete it like we did for from-bodyxml?

@adgad
Copy link
Collaborator Author

adgad commented Feb 16, 2026

@todor-videv1 have added those extra root files, and the two C&M library folders explicitly

I think we can get rid of to-string - will do that separately

@adgad adgad force-pushed the codeowner-changes branch from 53b61df to f8dd665 Compare February 16, 2026 11:19
- Add platforms to shared owners
- extend go to include markdown files
- add C&M/spark as owners of test fixtures
@adgad adgad force-pushed the codeowner-changes branch from f8dd665 to 48d5724 Compare February 16, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants