Conversation
.github/CODEOWNERS
Outdated
| # Shared ownership for SPEC and package.json (for version bumps) | ||
| SPEC.md @Financial-Times/content-team @Financial-Times/spark-team @Financial-Times/storytelling | ||
| package.json @Financial-Times/content-team @Financial-Times/spark-team @Financial-Times/storytelling |
There was a problem hiding this comment.
thought: as you know, your father, the king @Financial-Times/r13n was the API Rationalisation team; its ownership of cp-content-pipeline was subsumed by @Financial-Times/platforms. it's been rare that we've had a hand in work on content-tree itself but i feel like it's not unthinkable for us to be involved in reviewing things (i'm thinking of things like versioned components or potentially moving some of the model/strategy code into this repo)? 🤷🏻♀️
There was a problem hiding this comment.
ha, not at all!
I will add to you to the shared list, then future things like models we can cross when we get there
There was a problem hiding this comment.
I've also added README.md to that shared list, as I imagine that will encompass any significant changes as well
andy-little
left a comment
There was a problem hiding this comment.
Looks like a big improvement to me :)
These are the files/folders we should own I think. EDIT: Ah actually no, the |
|
@todor-videv1 have added those extra root files, and the two C&M library folders explicitly I think we can get rid of to-string - will do that separately |
53b61df to
f8dd665
Compare
- Add platforms to shared owners - extend go to include markdown files - add C&M/spark as owners of test fixtures
f8dd665 to
48d5724
Compare
From a Slack convo - this change hopes to give greater clarity and expectations over ownership and PR reviews for the repo.
The rationale:
*.goenough? or should it be something wider, like the folder?(didn't really know what to do with /tests - hopefully this is a good starting point that we can build on)