Conversation
katiefenn
force-pushed
the
add-subscript-and-superscript-support
branch
from
4cc1e8d to
fbbf27f
Compare
| ``` | ||
|
|
||
| **Superscript** represents a piece of text with a raised baseline. | ||
|
|
There was a problem hiding this comment.
☝️ Add support for new subscript (<sub>) and superscript (<sup>) formatted text to Content Tree.
- The Spark team are working on a piece of work to add support to subscript and superscript to Spark - This commit contains changes to Content Tree to add support for subscript and superscript text, via the <sup> and <sub> tags
katiefenn
force-pushed
the
add-subscript-and-superscript-support
branch
from
fbbf27f to
fd3c12d
Compare
| "value": " The English Stage Company at the Royal Court Theatre, headed by George Devine and Theatre Workshop organised by Joan Littlewood were particularly prominent in bringing these plays to public attention. Critic John Heilpern wrote that Look Back in Anger expressed such “immensity of feeling and class hatred” that it altered the course of English theatre. The term “Angry theatre” was coined by critic John Russell Taylor." | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
☝️ Add some test data for superscript text. 👇
| interface Superscript extends Parent { | ||
| type: "superscript"; | ||
| children: Phrasing[]; | ||
| } |
There was a problem hiding this comment.
☝️ All changes in this file are autogenerated from changes to README.md.
epavlova
left a comment
epavlova
left a comment
There was a problem hiding this comment.
note: On a note separate from this pr, the body xml should support subscript and superscript so there may be work in C&M related this.
|
|
||
| **Strikethrough** represents a piece of text that has been stricken. | ||
|
|
||
| ### `Subscript` |
There was a problem hiding this comment.
todo: If I'm not mistaken the json schemas will need to be updated.
For context, the C&M team will allow publishing of content tree next year and those schemas will be our source of truth for validation.
There was a problem hiding this comment.
The JSON schemas get automatically generated as part of the build step
I think what's missing (and why the JSON schemas haven't been updated yet) is that the new types need to be included as things that can be "Phrasing" - https://github.com/Financial-Times/content-tree/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R130
There was a problem hiding this comment.
I've just added Subscript and Superscript to the Phrasing types, and re-built the schema 👍
4 participants
<sup>and<sub>tags