Merged
Conversation
a9b88bd to
5355541
Compare
9dc9c54 to
58d9ae1
Compare
apaleslimghost
commented
Jul 1, 2025
olusoladavid
reviewed
Jul 2, 2025
Contributor
olusoladavid
left a comment
There was a problem hiding this comment.
Great work! Haven't had the chance to fully test the new UX but the code approach is solid 🔥 . Thanks for putting together. I added some questions in the meantime
109c49d to
4ddcf74
Compare
olusoladavid
approved these changes
Jul 14, 2025
Contributor
olusoladavid
left a comment
There was a problem hiding this comment.
sheer brilliance; thank you - there's the DX edge case I mentioned but I wouldn't consider it blocking for an initial rollout of this feature
just in case someone does something cursed with nested Parallel
so we can expand the possible values later
Co-authored-by: Olusola Oguntimehin <30433120+olusoladavid@users.noreply.github.com>
9c77843 to
6707b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements parallel task running in userland using a task with options, which looks like:
also includes some refactoring to the core that was necessary to get this working, and some refactoring that turned out not to be necessary.