Skip to content

[OR-1884] Arrange forms into agreed package structure#2343

Closed
j-mes wants to merge 4 commits intomainfrom
OR-1884-arrange-forms-into-agreed-package-structure
Closed

[OR-1884] Arrange forms into agreed package structure#2343
j-mes wants to merge 4 commits intomainfrom
OR-1884-arrange-forms-into-agreed-package-structure

Conversation

@j-mes
Copy link
Copy Markdown
Member

@j-mes j-mes commented Jan 19, 2026

TBD. Sharing PR for other Origami devs.

Copilot AI review requested due to automatic review settings January 19, 2026 14:44
@j-mes j-mes requested a review from a team as a code owner January 19, 2026 14:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes form components into a new package structure within the o3-foundation component library. The changes introduce TypeScript type definitions for form inputs and implement React components for various input types (text, password, file, date, select, checkbox, radio button) along with their supporting infrastructure.

Changes:

  • Added comprehensive TypeScript type definitions for all form input components
  • Implemented React components for text, password, file, date, select, checkbox, and radio button inputs
  • Created CSS styling for all form components with support for multiple brands
  • Added Storybook stories for component documentation and testing

Reviewed changes

Copilot reviewed 44 out of 46 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
components/o3-foundation/types/index.ts Defines TypeScript interfaces for all form input props
components/o3-foundation/tsconfig.json Enables JavaScript checking in TypeScript config
components/o3-foundation/src/tsx/index.ts Exports all form input components
components/o3-foundation/src/tsx/components/input/*.tsx Implements React components for various input types
components/o3-foundation/src/tsx/components/input/fieldComponents/*.tsx Provides shared form field wrapper components
components/o3-foundation/src/css/components/input/*.css Defines styles for all form components
components/o3-foundation/stories/*.stories.tsx Documents component usage with Storybook stories
components/o3-foundation/package.json Adds o-utils dependency
Comments suppressed due to low confidence (1)

components/o3-foundation/src/css/components/input/text-input copy.css:1

  • The filename 'text-input copy.css' appears to be an accidental duplicate. This file should either be renamed to a more descriptive name if it serves a different purpose, or removed if it's unintentional.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

/>
<TextInputTsx
label="Passcode"
description="A 5-digin code to authenticate you on login"
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'digin' to 'digit'.

Suggested change
description="A 5-digin code to authenticate you on login"
description="A 5-digit code to authenticate you on login"

Copilot uses AI. Check for mistakes.
disabled?: boolean;
feedback?: FeedbackProps;
forgotPasswordLink?: string;

Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary blank line at the end of PasswordInputProps interface.

Suggested change

Copilot uses AI. Check for mistakes.
@j-mes j-mes force-pushed the OR-1884-arrange-forms-into-agreed-package-structure branch 5 times, most recently from cd9b186 to c749958 Compare January 19, 2026 15:05
@joelcarr
Copy link
Copy Markdown
Member

joelcarr commented Mar 9, 2026

We have discussed as a team and have decided to keep the o3-form package structure as is.

@joelcarr joelcarr closed this Mar 9, 2026
@j-mes j-mes deleted the OR-1884-arrange-forms-into-agreed-package-structure branch April 29, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants