[OR-1884] Arrange forms into agreed package structure#2343
[OR-1884] Arrange forms into agreed package structure#2343
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reorganizes form components into a new package structure within the o3-foundation component library. The changes introduce TypeScript type definitions for form inputs and implement React components for various input types (text, password, file, date, select, checkbox, radio button) along with their supporting infrastructure.
Changes:
- Added comprehensive TypeScript type definitions for all form input components
- Implemented React components for text, password, file, date, select, checkbox, and radio button inputs
- Created CSS styling for all form components with support for multiple brands
- Added Storybook stories for component documentation and testing
Reviewed changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| components/o3-foundation/types/index.ts | Defines TypeScript interfaces for all form input props |
| components/o3-foundation/tsconfig.json | Enables JavaScript checking in TypeScript config |
| components/o3-foundation/src/tsx/index.ts | Exports all form input components |
| components/o3-foundation/src/tsx/components/input/*.tsx | Implements React components for various input types |
| components/o3-foundation/src/tsx/components/input/fieldComponents/*.tsx | Provides shared form field wrapper components |
| components/o3-foundation/src/css/components/input/*.css | Defines styles for all form components |
| components/o3-foundation/stories/*.stories.tsx | Documents component usage with Storybook stories |
| components/o3-foundation/package.json | Adds o-utils dependency |
Comments suppressed due to low confidence (1)
components/o3-foundation/src/css/components/input/text-input copy.css:1
- The filename 'text-input copy.css' appears to be an accidental duplicate. This file should either be renamed to a more descriptive name if it serves a different purpose, or removed if it's unintentional.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /> | ||
| <TextInputTsx | ||
| label="Passcode" | ||
| description="A 5-digin code to authenticate you on login" |
There was a problem hiding this comment.
Corrected spelling of 'digin' to 'digit'.
| description="A 5-digin code to authenticate you on login" | |
| description="A 5-digit code to authenticate you on login" |
| disabled?: boolean; | ||
| feedback?: FeedbackProps; | ||
| forgotPasswordLink?: string; | ||
|
|
There was a problem hiding this comment.
Remove unnecessary blank line at the end of PasswordInputProps interface.
cd9b186 to
c749958
Compare
|
We have discussed as a team and have decided to keep the o3-form package structure as is. |
TBD. Sharing PR for other Origami devs.