Conversation
fenglish
force-pushed
the
CULT-747
branch
2 times, most recently
from
d7cdec1 to
39f7fbb
Compare
fenglish
commented
Jan 28, 2026
fenglish
commented
Jan 28, 2026
fenglish
force-pushed
the
CULT-747
branch
2 times, most recently
from
95bd28d to
f2ec30f
Compare
kavanagh
reviewed
Jan 28, 2026
kavanagh
reviewed
Jan 28, 2026
kavanagh
reviewed
Jan 28, 2026
fenglish
force-pushed
the
CULT-747
branch
2 times, most recently
from
9fd4891 to
2f35866
Compare
kavanagh
reviewed
Jan 29, 2026
fenglish
force-pushed
the
CULT-747
branch
18 times, most recently
from
19a6d49 to
9755cc1
Compare
metart43
reviewed
Feb 9, 2026
Member
metart43
left a comment
metart43
left a comment
There was a problem hiding this comment.
This looks good Asuka. I am just commenting on the code, there are a few non-blocking comments/question.
I haven't ran the storybook and see the component yet.
fenglish
force-pushed
the
CULT-747
branch
2 times, most recently
from
80c1ed7 to
b00df03
Compare
metart43
approved these changes
Feb 10, 2026
kavanagh
reviewed
Feb 11, 2026
kavanagh
reviewed
Feb 16, 2026
The author headshot has been moved into a new Byline component. The latest design no longer displays the headshot on the right side. The legacy headshot component is still kept for consumers that need it. By default, showByline is set to true in presets, so the new component is applied automatically. Consumers can set showByline to false to continue using the legacy headshot behaviour. To migrate to the new Byline component, teaser data must include a byline property in the following format: `byline: [[ AuthorNameString, LinkUrlString?, HeadshotString?]]`
fenglish
requested review from
a team and
ft-dependency-auto-merger
as code owners
kavanagh
approved these changes
Feb 17, 2026
Member
kavanagh
left a comment
kavanagh
left a comment
There was a problem hiding this comment.
This is looking great to me. It's hard to add changes like this elegantly while keeping as much back compatibility as possible. So well done.
j-mes
approved these changes
Feb 18, 2026
Member
j-mes
left a comment
j-mes
left a comment
There was a problem hiding this comment.
Firstly, I can see this PR has been thoroughly reviewed by @kavanagh and @metart43 so thank you for that.
Secondly, your PR description is a great piece of work. That provided me with enough context to look at this PR. I like the use of caution and so on!
Thirdly, having gone through every file you've edited there, I don't see any issues with this PR being merged. Do you have any concerns @joelcarr?
joelcarr
reviewed
Feb 18, 2026
Member
joelcarr
left a comment
joelcarr
left a comment
There was a problem hiding this comment.
+1 to everything @j-mes said! Exceptional PR 👏🏻 Please could you add the steps to handle the breaking change in https://github.com/Financial-Times/origami/blob/main/components/o-teaser/MIGRATION.md
joelcarr
approved these changes
Feb 19, 2026
Member
joelcarr
left a comment
joelcarr
left a comment
There was a problem hiding this comment.
Wonderful! Happy for this CULT-747 to take off
fenglish
added a commit
that referenced
this pull request
Mar 11, 2026
A change in #2356 added a teaser title indicator icon for opinion teasers. However, live blog posts already had an existing opinion indicator icon. The new styling unintentionally overrode the old styling and caused the icon to display incorrectly. The old styling specific to live blog posts is no longer needed, as the new styling now provides the opinion indicator consistently across all teaser types.
fenglish
added a commit
that referenced
this pull request
Mar 11, 2026
A change in #2356 added a teaser title indicator icon for opinion teasers. However, live blog posts already had an existing opinion indicator icon. The new styling unintentionally overrode the old styling and caused the icon to display incorrectly. The old styling specific to live blog posts is no longer needed, as the new styling now provides the opinion indicator consistently across all teaser types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Product Curation & Loyalty team is working on Opinion teaser improvements.
To achieve the improvement, x-teaser & o-teaser need to handle new teaser properties.
bylinemetaLinkstitlePrefixThese properties are used to control and display the components below.
Title Indicator for Opinion
The styling is applied using a combination of
o-teaser--opinionando-teaser--heading.TitlePrefix
showTitlePrefixtruetitlePrefixshowTitleandshowTitlePrefixaretrue, and thetitlePrefixproperty is set.Byline
Caution
Breaking change!!
The Byline component is enabled by default, as
showBylineis set totrue.This means the Byline will be rendered instead of the legacy Headshot component when byline data is available.
If your application is not ready to adopt the Byline component yet, it can opt out by explicitly setting
showBylinetofalse.In that case, the existing Headshot behaviour will remain unchanged.
showBylinetruebyline[authorName, linkUrl, headshot]showBylineistrueand thebylineproperty is set.showBylineandshowBylineHeadshotaretrue, and thebylineentry includes a headshot value (index 2).showBylinetakes precedence overshowHeadshot, so it will NOT fall back to a headshot even if old (withoutbyline) and new content (withbyline) models exist on the same page.