fix: dedupe volume mount targets during recreate#765
Open
itsDNNS wants to merge 1 commit intoFinsys:mainfrom
Open
fix: dedupe volume mount targets during recreate#765itsDNNS wants to merge 1 commit intoFinsys:mainfrom
itsDNNS wants to merge 1 commit intoFinsys:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes a duplicate mount target during recreate/self-update on setups where Docker reports named volumes in
HostConfig.Mountsinstead ofHostConfig.Binds. In that case Dockhand was only checkingBinds, then adding the same destination again frominspectData.Mounts, which leads to errors likeDuplicate mount point: /data.The patch reuses one dedupe helper in both recreate paths and adds a small regression test covering the existing-target and missing-target cases.
Tested with:
npx tsx --test src/lib/server/mount-dedupe.test.tsCloses #764
Type of change