Skip to content

Improve CFDP Unit Tests#15

Merged
pepepr08 merged 24 commits into
cfdp-mergefrom
cfdp-ut
Jul 13, 2026
Merged

Improve CFDP Unit Tests#15
pepepr08 merged 24 commits into
cfdp-mergefrom
cfdp-ut

Conversation

@pepepr08

@pepepr08 pepepr08 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator
Related Issue(s)
Has Unit Tests (y/n) y
Documentation Included (y/n) n
Generative AI was used in this contribution (y/n) y

Change Description

Pull request to address unit tests related comments at: nasa#5138

Summary of comments in CFDP-merge PR:

  1. Fix 8 of 9 new async commands have no test coverage.
  2. ~53 of 55 new events have no ASSERT_EVENTS_* coverage
  3. fix None of the 10 new parameters have paramSet_* / paramGet_* test coverage.
  4. New async input port dataReturnIn has no test invocation.
  5. SendFile (the only tested command) lacks failure-path coverage.
  6. Multi-instance ports (dataOut, dataIn, bufferAllocate, etc.) are exercised on channel 0 for most test paths.
  7. Telemetry counter assertions use EXPECT_GE lower bounds instead of exact values.

Rationale

Improve

Testing/Review Recommendations

Ran CfdpManager Unit Tests. Coverage now at ~89%

Future Work

Improve coverage

AI Usage (see policy)

Planning, code generation and debugging

@pepepr08
pepepr08 marked this pull request as ready for review July 8, 2026 21:58
@pepepr08
pepepr08 marked this pull request as draft July 8, 2026 21:58
@pepepr08
pepepr08 requested a review from Brian-Campuzano July 8, 2026 21:58
@pepepr08 pepepr08 self-assigned this Jul 8, 2026
@pepepr08
pepepr08 marked this pull request as ready for review July 10, 2026 16:22
Comment thread Svc/Ccsds/CfdpManager/Events.fppi
Comment thread Svc/Ccsds/CfdpManager/test/ut/CfdpManagerCommandTests.cpp Outdated
Comment thread Svc/Ccsds/CfdpManager/test/ut/CfdpManagerEventTests.cpp
Comment thread Svc/Ccsds/CfdpManager/test/ut/CfdpManagerTester.cpp Outdated
@pepepr08
pepepr08 merged commit 97ea51c into cfdp-merge Jul 13, 2026
1 check passed
@pepepr08
pepepr08 deleted the cfdp-ut branch July 13, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants