This repository was archived by the owner on Jun 16, 2018. It is now read-only.
Ip autoconfig#37
Open
itamargreen wants to merge 9 commits intoFirstLegoLeague:gh-pagesfrom
itamargreen:ip-autoconfig
Open
Ip autoconfig#37itamargreen wants to merge 9 commits intoFirstLegoLeague:gh-pagesfrom itamargreen:ip-autoconfig
itamargreen wants to merge 9 commits intoFirstLegoLeague:gh-pagesfrom
itamargreen:ip-autoconfig
Conversation
Member
|
This PR seems to mix multiple new features, as there are table styling commits as well Please offer them as separate PRs, the way to do that is to have different branches based on the most recent head |
Member
|
Also, having a hardcoded IP in the default config would not work in the majority of cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a different computer to connect to the IPv4 of the computer running the display system, and it'll show the sprites and data (using
window.location.hostnameinstead of hardcodedlocalhost).