Skip to content
This repository was archived by the owner on Jun 16, 2018. It is now read-only.

Added the current score to the appbar in scoresheet.html#263

Open
ThinkRedstone wants to merge 3 commits intoFirstLegoLeague:masterfrom
ThinkRedstone:show-score
Open

Added the current score to the appbar in scoresheet.html#263
ThinkRedstone wants to merge 3 commits intoFirstLegoLeague:masterfrom
ThinkRedstone:show-score

Conversation

@ThinkRedstone
Copy link

No description provided.

@poelstra
Copy link
Collaborator

Don't think using <h3> is the best option to do this, because it's semantically not a header but 'just' a piece of info. So probably a <span class="score"> or something is better.

However, I don't think it's a big issue, so:

  • it would be nice if you can change it
  • otherwise, just let me know, and I'll merge it as-is

@alanggreen
Copy link

@ThinkRedstone I think @poelstra 's point about H3 is valid

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants