Fix/put things in order#20
Merged
Merged
Conversation
… all SQL queries to reduce the IO load.
Contributor
Руководство для ревьюера (свернуто для небольших PR)Руководство для ревьюераУдаляет отладочную конфигурацию и неиспользуемый инфраструктурный код и исправляет истечение срока действия JWT, чтобы использовать осведомлённые о временной зоне даты и время в UTC. Изменения на уровне файлов
Подсказки и командыВзаимодействие с Sourcery
Настройка работыПерейдите в вашу панель управления, чтобы:
Получение помощи
Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves debugging configuration and unused infrastructure code and fixes JWT expiration to use timezone-aware UTC datetimes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Привет — я оставил несколько общих замечаний:
- Вместо того чтобы жёстко убирать
echo=Trueиз движка SQLAlchemy, рассмотрите возможность привязать его к флагу конфигурации или переменной окружения, чтобы можно было легко включать и выключать логирование SQL-запросов в разных средах. - Теперь, когда время истечения срока действия JWT использует осведомлённый о временной зоне объект
datetime(datetime.now(timezone.utc)), имеет смысл стандартизировать использование таких «осведомлённых»datetimeпо всему слою аутентификации, чтобы избежать смешивания «наивных» и «осведомлённых» временных меток.
Подсказка для AI-агентов
Please address the comments from this code review:
## Overall Comments
- Instead of hard-removing `echo=True` from the SQLAlchemy engine, consider wiring it to a configuration flag or environment variable so you can easily toggle SQL query logging in different environments.
- Now that JWT expiration uses a timezone-aware `datetime` (`datetime.now(timezone.utc)`), consider standardizing on timezone-aware datetimes across the auth layer to avoid mixing naive and aware timestamps.Sourcery бесплатен для open source — если вам нравятся наши ревью, пожалуйста, расскажите о них ✨
Original comment in English
Hey - I've left some high level feedback:
- Instead of hard-removing
echo=Truefrom the SQLAlchemy engine, consider wiring it to a configuration flag or environment variable so you can easily toggle SQL query logging in different environments. - Now that JWT expiration uses a timezone-aware
datetime(datetime.now(timezone.utc)), consider standardizing on timezone-aware datetimes across the auth layer to avoid mixing naive and aware timestamps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of hard-removing `echo=True` from the SQLAlchemy engine, consider wiring it to a configuration flag or environment variable so you can easily toggle SQL query logging in different environments.
- Now that JWT expiration uses a timezone-aware `datetime` (`datetime.now(timezone.utc)`), consider standardizing on timezone-aware datetimes across the auth layer to avoid mixing naive and aware timestamps.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Coverage Report for CI Build 26332470097Coverage increased (+0.2%) to 28.248%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Согласовать обработку datetime и очистить устаревшие служебные утилиты базы данных.
Исправления ошибок:
Улучшения:
echoпри создании асинхронного engine.Обслуживание:
get_dbиз инфраструктурного слоя.Original summary in English
Summary by Sourcery
Align datetime handling and clean up obsolete database utilities.
Bug Fixes:
Enhancements:
Chores: