feat: removed hard-coded configuration parameters in preparation for automated client deployment - #65
Merged
Merged
Conversation
bakirFS
force-pushed
the
feat/switch-to-github-variables
branch
from
July 17, 2026 16:01
238d4f1 to
6f71b54
Compare
Prevents the encryption prompt from failing the deploy in CI's non-TTY environment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
matthewelwell
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #59
Created this PR to remove hard-coded variables from code which caused us to have bespoke deployments for each customer using private cloud.
You need to provide 4 values at all time in GitHub variables + FORGE_API_TOKEN in secrets.
Those are: FLAGSMITH_BACKEND_HOST, FORGE_APP_ID, FLAGSMITH_APP and FLAGSMITH_API_V1.
Changes have been tested by providing invalid manifest variables (FLAGSMITH_BACKEND_HOST) which made the deployment fail and by providing invalid runtime variables (FLAGSMITH_API_V1) which deployed the app but not communicate with the API.