Skip to content

ci: publish-internal-version-action-workflow#378

Merged
Zaimwa9 merged 7 commits intomainfrom
feat/publish-internal-version-workflow
Mar 4, 2026
Merged

ci: publish-internal-version-action-workflow#378
Zaimwa9 merged 7 commits intomainfrom
feat/publish-internal-version-workflow

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Mar 4, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #377

  • Created .github/workflows/publish-internal.yml to manual dispatch workflow to publish packages with internal tag (based on publish.yml)

Steps:

  1. Bump to a higher version with tag internal (with an increment if multiple releases needed e.g 11.1.0-internal.1)
  2. Trigger Publish Internal NPM Package from action
  3. Run workflow with selected branch

Usage in app with
npm i flagsmith@11.1.0-internal.1

Bonus

  • Added the pull request template

How did you test this code?

  • Not yet

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner March 4, 2026 11:57
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team March 4, 2026 11:57
@germangarces
Copy link

Bump to a higher version with tag internal

Is this prone to failure? Could we document it or get the workflow to do it on its own?

@khvn26
Copy link
Member

khvn26 commented Mar 4, 2026

@germangarces see #379.

@Zaimwa9 Zaimwa9 requested a review from germangarces March 4, 2026 13:12
@Zaimwa9
Copy link
Contributor Author

Zaimwa9 commented Mar 4, 2026

My bad, I forgot we did add release-please and it's taking care of the version bumps now. Only on main though.

I'm exploring the possibilities right now. But as the idea was to not have to merge internal versions into main, the solution might be simpler than I thought and not so "semverically" hideous.

What do you think about:

  • Having the workflow suffix the current version with internal.{runNumber} (without merging) -> npm will consider as a distinct version so no conflict
  • Testing how much we want the internal version
  • Once complete and meant to be merged release please will deal with correct versioning without having a dirty version history

cc @khvn26 i'll close your issue

@germangarces
Copy link

LGTM :)

@Zaimwa9 Zaimwa9 changed the title feat: publish-internal-version-action-workflow ci: publish-internal-version-action-workflow Mar 4, 2026
@Zaimwa9 Zaimwa9 merged commit 02b1892 into main Mar 4, 2026
2 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/publish-internal-version-workflow branch March 4, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants