-
-
Notifications
You must be signed in to change notification settings - Fork 2
docs: record upstream release limits #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,21 @@ Three reach npm for the first time in this release: | |
| `tonyketcham/flatbread` fork. | ||
| - Every package carries a description that says what that package does. | ||
|
|
||
| ### Known dependency limits | ||
|
|
||
| A clean install of all twelve packages reports seven `npm audit` entries that | ||
| npm marks as having no fix available; the main `flatbread` install and its | ||
| nine-package set report none, so the two packages below do not affect it. | ||
|
Comment on lines
+64
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HIGH — “its nine-package set” can be read as the nine alpha packages listed earlier in this file (lines 14–19), which includes Minimal fix: say “flatbread’s nine direct |
||
|
|
||
| - `@flatbread/proof` inherits three moderate and high entries from | ||
| `@cursor/sdk`, which depends on `@connectrpc/connect-node@1.x` and through it | ||
| `undici@5.x`. No current or later `@cursor/sdk` release clears them, and the | ||
| later releases require Node 22.13 or newer. | ||
|
Comment on lines
+68
to
+71
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MED (consensus) — “three moderate and high entries” is grammatically ambiguous and does not match a clear severity split readers will see in Minimal fix: Rewrite to an explicit split — prefer “three moderate and one high” / “four entries: three moderate, one high” (including the
Comment on lines
+68
to
+71
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MED — “inherits three moderate and high entries” reads as three total and undercounts a proof-only packed install (four entries: three moderate, one high — proof / Minimal fix: spell out “three moderate and one high” (or “four entries: three moderate, one high”) so the 4+3=7 split stays auditable. |
||
| - `@flatbread/resolver-svimg` inherits four high entries from its required peer | ||
| `svimg`, which depends on `sharp`. The latest `svimg@4` still pins `sharp` | ||
| below the patched 0.35 line, and it changes the import API this resolver | ||
| uses. | ||
|
Comment on lines
+72
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HIGH (consensus) — This bullet says Minimal fix: Change “four high entries” to “three high entries” (optionally note they are three of the release’s four highs).
Comment on lines
+72
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HIGH — “inherits four high entries” does not match a packed install of Minimal fix: change “four” → “three”. Keep the |
||
|
|
||
| ### Docs | ||
|
|
||
| - The READMEs and `docs/positioning.md` now lead with the Effort Graph: an | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MED (consensus) — “nine-package set” collides with the earlier “Nine were already on npm as alphas” list (a different nine that includes
resolver-svimgand excludeseffort-graph/explorer). Readers may think the alpha cohort is the cleanflatbreadinstall path.LOW — “A clean install of all twelve packages” also underspecifies how to reproduce the seven-entry audit (peer
svimgis required for the sharp chain).Minimal fix: Rename to something explicit such as “flatbread’s nine
@flatbread/*runtime dependencies,” and add a short repro qualifier (install all twelve1.0.0packages withsvimg@3, thennpm audit).