swift 3 builds and fixed some nsnumber values for correct default slider values#31
Open
mredig wants to merge 1 commit intoFlexMonkey:swift-3from
Open
swift 3 builds and fixed some nsnumber values for correct default slider values#31mredig wants to merge 1 commit intoFlexMonkey:swift-3from
mredig wants to merge 1 commit intoFlexMonkey:swift-3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the edits were actually pulled from another fork I picked at random that fixed the swift 3 build issues.
However, I noticed that a lot of filters has horrible slider ranges and default values (I believe as a result of the swift 3 conversion), so I found the issue and cast the filter values as NSNumbers and then used the "floatValue" of an NSNumber to get those min, max, and default values, instead of casting NSNumbers as Float.