Skip to content

Fix: 카드셋 url 수정 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stoneTiger0912 merged 2 commits into from
Mar 16, 2026
Merged

Fix: 카드셋 url 수정 #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a3bec
Fix: 카드셋 url 수정
stoneTiger0912 Mar 16, 2026
216fc80
Fix: 카드셋 url 수정
stoneTiger0912 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,30 @@ spring:
predicates:
- Path=/groups/actuator/health

- id: cardset-swagger
uri: http://cardset-service:8085
predicates:
- name: Path
args:
patterns:
- /card-sets/swagger-ui.html
- /card-sets/swagger-ui/**
- /card-sets/v3/api-docs
- /card-sets/v3/api-docs/**

- id: cardset-health
uri: http://cardset-service:8085
predicates:
- Path=/card-sets/health
Comment on lines +132 to +135
Copy link

@coderabbitai coderabbitai bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# 목적: 저장소 내 헬스체크 경로 패턴 일관성 확인 (read-only)
rg -n --glob '*.yml' -e '/card-sets/health' -e '/card-sets/actuator/health' -e '/actuator/health'
rg -n --glob '*.yml' -e 'cardset-health' -e 'group-health' -e 'readiness' -e 'liveness'

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 481

🏁 Script executed:

cd src/main/resources && cat -n application.yml | sed -n '110,140p'

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 1219

🏁 Script executed:

# cardset-service 설정이나 문서 검색
rg -i 'cardset.*health|health.*cardset' --type yml --type yaml --type java --type md

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 100

🏁 Script executed:

# Actuator 설정 또는 context-path 관련 설정 확인
rg -n 'management:' -A 10 src/main/resources/application.yml

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 279

🏁 Script executed:

# 두 서비스의 전체 라우팅 설정 확인
fd -e yml -e yaml src/main/resources | xargs cat -n

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 450

🏁 Script executed:

# 모든 YAML 파일 찾기
fd . src/main/resources -name "*.yml" -o -name "*.yaml"

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 303

🏁 Script executed:

# cardset-service와 관련된 모든 참조 찾기
rg 'cardset' -i --type-list

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 462

🏁 Script executed:

# README나 문서에서 엔드포인트 정보 확인
fd README -o -name "*.md" | head -5 | xargs cat 2>/dev/null | head -100

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 303

🏁 Script executed:

# 모든 YAML 파일 찾기 (수정된 명령)
fd '\.ya?ml$' src/main/resources

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 148

🏁 Script executed:

# cardset 관련 모든 참조 찾기
rg 'cardset' --ignore-case

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 769

🏁 Script executed:

# 문서 파일 찾기 및 확인
find . -maxdepth 2 -name "README*" -o -name "*.md" | head -10

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 55

🏁 Script executed:

# application-local.yml 확인
cat src/main/resources/application-local.yml

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 3204

🏁 Script executed:

# application.yml에서 cardset-health 라우트 주변 전체 컨텍스트 확인
sed -n '130,145p' src/main/resources/application.yml

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 518

🏁 Script executed:

# group-health 라우트도 다시 확인
sed -n '114,125p' src/main/resources/application.yml

Repository: FlipNoteTeam/FlipNote-Gateway

Length of output: 390

cardset-health 라우트의 경로가 그룹 헬스체크 패턴과 불일치합니다.

/card-sets/health는 Spring Boot Actuator 규칙을 따르지 않습니다. 같은 파일에서 group-health는 /groups/actuator/health를 사용하는데, cardset-service도 Actuator 기반이라면 경로가 /card-sets/actuator/health로 수정되어야 합니다. 현재 경로로는 헬스체크가 실패할 가능성이 높습니다.

경로 비교 
- id: group-health
  uri: http://group-service:8084
  predicates:
    - Path=/groups/actuator/health    # Actuator 규칙 준수

- id: cardset-health
  uri: http://cardset-service:8085
  predicates:
    - Path=/card-sets/health          # Actuator 규칙 미준수
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/main/resources/application.yml` around lines 132 - 135, The
cardset-health route's predicate Path (/card-sets/health) doesn't follow the
Actuator pattern used by group-health; update the cardset-health route (id:
cardset-health) predicate to use the Actuator endpoint path
(/card-sets/actuator/health) so it matches the group-health convention and
ensures proper health checks for cardset-service.


- id: cardset-private
uri: http://cardset-service:8085
predicates:
- name: Path
args:
patterns:
- /v1/cardsets
- /v1/cardsets/**
- /v1/card-sets
- /v1/card-sets/**
- /v1/cards
- /v1/cards/**
filters:
Expand All @@ -134,21 +150,10 @@ spring:
- id: cardset-websocket
uri: ws://cardset-service:8085
predicates:
- Path=/cardsets/**
- Path=/v1/card-sets/ws/**
filters:
- AuthenticationFilter

- id: cardset-swagger
uri: http://cardset-service:8085
predicates:
- name: Path
args:
patterns:
- /cardsets/swagger-ui.html
- /cardsets/swagger-ui/**
- /cardsets/v3/api-docs
- /cardsets/v3/api-docs/**

app:
user-service:
url: http://user-service:8081
Expand Down
Loading