Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
WalkthroughgRPC와 protobuf를 활용하여 CardSet 서비스 통합을 추가했으며, RabbitTemplate 직접 사용을 ReactionEventPublisher 추상화로 변경하고, 북마크 및 좋아요 응답에 targetGroupId 필드를 추가했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Service as BookmarkService
participant EventPub as ReactionEventPublisher
participant GrpcClient as CardSetGrpcClient
participant RabbitMQ
participant CardSetService as CardSet<br/>Service
Client->>Service: addBookmark(bookmark, CARD_SET)
activate Service
Service->>GrpcClient: isCardSetViewable(cardSetId, userId)
activate GrpcClient
GrpcClient->>CardSetService: IsCardSetViewableRequest
CardSetService-->>GrpcClient: IsCardSetViewableResponse
GrpcClient-->>Service: boolean viewable
deactivate GrpcClient
alt viewable
Service->>Service: save bookmark
Service->>EventPub: publish(routingKey, eventType, CARD_SET, cardSetId, userId)
activate EventPub
EventPub->>RabbitMQ: send ReactionMessage
RabbitMQ-->>EventPub: ack
deactivate EventPub
Service-->>Client: success
else not viewable
Service-->>Client: TARGET_NOT_VIEWABLE error
end
deactivate Service
sequenceDiagram
participant Client
participant Service as LikeService
participant GrpcClient as CardSetGrpcClient
participant CardSetService as CardSet<br/>Service
participant Database
Client->>Service: getLikes(userId)
activate Service
Service->>Database: query likes
Database-->>Service: List<Like>
Service->>GrpcClient: getCardSetsByIds(cardSetIds, userId)
activate GrpcClient
GrpcClient->>CardSetService: GetCardSetsByIdsRequest
CardSetService-->>GrpcClient: GetCardSetsByIdsResponse<br/>(CardSetSummaries)
GrpcClient-->>Service: Map<cardSetId, CardSetSummary>
deactivate GrpcClient
Service->>Service: build LikeResponse<br/>with targetGroupId<br/>from summaryMap
Service-->>Client: List<LikeResponse>
deactivate Service
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
릴리스 노트
새로운 기능
버그 수정
Chores