Skip to content

Fix: OAuth 인증 기능 정상화#8

Merged
dungbik merged 1 commit intomainfrom
feat/fix-oauth
Mar 14, 2026
Merged

Fix: OAuth 인증 기능 정상화#8
dungbik merged 1 commit intomainfrom
feat/fix-oauth

Conversation

@dungbik
Copy link
Contributor

@dungbik dungbik commented Mar 14, 2026

Summary by CodeRabbit

릴리스 노트

  • Bug Fixes

    • 소셜 로그인 실패 시 명확한 오류 처리 및 리다이렉트 개선
  • Refactor

    • OAuth 인증 흐름 간소화로 안정성 향상
    • 소셜 계정 연동 프로세스 최적화

@dungbik dungbik requested a review from stoneTiger0912 March 14, 2026 13:08
@dungbik dungbik self-assigned this Mar 14, 2026
@dungbik dungbik added the enhancement New feature or request label Mar 14, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49c19c4c-6f71-41d7-bcb4-29e441063ad6

📥 Commits

Reviewing files that changed from the base of the PR and between 8485a47 and 1d7d8fa.

📒 Files selected for processing (5)
  • src/main/java/flipnote/user/auth/application/OAuthService.java
  • src/main/java/flipnote/user/auth/infrastructure/oauth/OAuthApiClient.java
  • src/main/java/flipnote/user/auth/presentation/OAuthController.java
  • src/main/java/flipnote/user/global/config/OAuthProperties.java
  • src/main/resources/application.yml

Walkthrough

HttpServletRequest 매개변수를 OAuth 서비스, 인프라, 컨트롤러 계층에서 제거하고, 요청 기반 리다이렉트 URI 구성을 provider 기반 baseUrl 로직으로 변경했습니다. OAuthProperties에 baseUrl 필드를 추가했습니다.

Changes

Cohort / File(s) Summary
OAuth 서비스 계층
flipnote/user/auth/application/OAuthService.java
4개 public/private 메서드에서 HttpServletRequest 매개변수 제거: getAuthorizationUri, socialLogin, linkSocialAccount, getOAuth2UserInfo
OAuth 인프라 계층
flipnote/user/auth/infrastructure/oauth/OAuthApiClient.java
HttpServletRequest 매개변수 제거 및 buildRedirectUri 로직 변경: 요청 기반에서 OAuthProperties.baseUrl + 경로 기반으로 전환
OAuth 컨트롤러
flipnote/user/auth/presentation/OAuthController.java
redirectToProvider, handleCallback, handleSocialLogin, handleSocialLink에서 HttpServletRequest 제거; handleSocialLogin에 예외 처리 추가
설정 파일
flipnote/user/global/config/OAuthProperties.java, src/main/resources/application.yml
OAuthProperties에 baseUrl 필드 추가 및 getter 자동 생성, application.yml에 oauth2.base-url 설정 추가

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 요청 객체는 이제 안녕,
baseUrl로 더 깔끔하게 변신!
OAuth 흐름이 슬림해졌고,
설정만으로 충분하네요.
토끼가 흔들며 축하합니다! 🎉

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/fix-oauth
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dungbik dungbik merged commit fd1e20e into main Mar 14, 2026
2 of 3 checks passed
@dungbik dungbik deleted the feat/fix-oauth branch March 14, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant