Skip to content

fix(ci): preserve isolated runner cleanup time#164

Merged
abiorh-claw merged 9 commits into
mainfrom
codex/ws-ci-001-01r1-timeout-cleanup
Jul 20, 2026
Merged

fix(ci): preserve isolated runner cleanup time#164
abiorh-claw merged 9 commits into
mainfrom
codex/ws-ci-001-01r1-timeout-cleanup

Conversation

@Abiorh001

Copy link
Copy Markdown
Collaborator

Chunk / Goal

WS-CI-001-01R1 repairs the valid CodeRabbit timeout finding posted on merged PR #163. Isolated child runners must time out before their enclosing GitHub jobs so repository-owned process termination and database cleanup retain operational headroom.

Human-Approved Intent

The user explicitly asked to fix the CodeRabbit comment. This is a bounded post-merge repair based on trusted main; WS-CI-001-02 remains inactive.

What Changed

  • Shard child timeout: 12,600s to 4,800s inside a 90-minute job.
  • API E2E child timeout: 3,600s to 1,500s inside a 30-minute job.
  • Workflow regression assertions bind both values and minimum configured budget gaps.
  • Added the R1 chunk contract, merge intent, external-review response, and trust bundle.

Why / Alternatives

GitHub could previously hard-cancel the job before the isolated runner completed cleanup. Increasing job budgets was rejected because the child values were already far above observed runtimes. The configured 600s/300s gaps are operational headroom, not guaranteed cleanup durations because setup also consumes job time.

Scope Control

No application code, schema, dependency, test selection, coverage threshold, required check, permission, authentication, authorization, product lifecycle, or merge authority changed.

Commands Run

  • Ruff format/lint: passed.
  • Shard and coverage-contract tests: 204 passed.
  • PostgreSQL isolated-runner tests: 16 passed.
  • Agent-gate workflow tests: 91 passed.
  • Markdown links, stale wording, loop state, and diff integrity: passed.

Result Summary

The isolated runners now fail first and retain operational cleanup headroom before GitHub job deadlines. Existing fail-closed propagation remains intact.

Acceptance Criteria

  • Shard child timeout is below its job budget by at least 600s.
  • API child timeout is below its job budget by at least 300s.
  • Regression assertions bind both relationships.
  • Real cleanup tests pass.
  • All required internal reviews pass.
  • Hosted Backend, Agent Gates, and external review pass.

Test Delta

One existing workflow-integrity test was strengthened. No tests or assertions were removed, skipped, or weakened.

Internal Review

Senior engineering, QA/test, security/auth, product/ops, architecture, CI integrity, docs, reuse/dedup, and test-delta all passed. Documentation-relevant tracks additionally confirmed the chunk-map and evidence-only corrections.

CI / Gate Integrity

Coverage floors, full-suite selection, fixed artifact fan-in, Backend / test, failure propagation, and human merge authority are unchanged.

Human Review Focus

Confirm timeout values remain sufficient for observed workloads, strictly below job budgets, and preserve child termination and owned database cleanup.

Trust Bundle

.agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/reviews/WS-CI-001-01R1-pr-trust-bundle.md

Merge intent: .agent-loop/merge-intents/WS-CI-001-01R1.json

Human approval is required before merge.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Abiorh001, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d6715c5f-7667-431c-9f81-4b9109a65c43

📥 Commits

Reviewing files that changed from the base of the PR and between b0f9ad6 and aa73e10.

📒 Files selected for processing (10)
  • .agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/CHUNK_MAP.md
  • .agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/STATUS.md
  • .agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/chunks/WS-CI-001-01R1-timeout-cleanup.md
  • .agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/reviews/WS-CI-001-01R1-external-review-response.md
  • .agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/reviews/WS-CI-001-01R1-internal-review-evidence.md
  • .agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/reviews/WS-CI-001-01R1-pr-trust-bundle.md
  • .agent-loop/merge-intents/WS-CI-001-01R1.json
  • .github/workflows/backend.yml
  • backend/scripts/ci_test_shards.py
  • scripts/test_agent_gates.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ws-ci-001-01r1-timeout-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@abiorh-claw
abiorh-claw self-requested a review July 20, 2026 18:46
@abiorh-claw
abiorh-claw merged commit 61bc039 into main Jul 20, 2026
9 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 20, 2026
@abiorh-claw
abiorh-claw deleted the codex/ws-ci-001-01r1-timeout-cleanup branch July 20, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants