-
Notifications
You must be signed in to change notification settings - Fork 6
WS-XINT-002-03: activate internal artifact services #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abiorh-claw
merged 8 commits into
main
from
codex/ws-xint-002-03-internal-service-activation
Jul 28, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ccb0249
feat(auth): activate internal artifact services
Abiorh001 11783f8
test(auth): enforce two-phase artifact authority
Abiorh001 74370da
fix(artifacts): scope provider runtime to worker process
Abiorh001 c17e6a3
test(migrations): recognize authorization evidence head
Abiorh001 ea026ac
fix(workers): initialize artifact runtime for eager tasks
Abiorh001 d0d0a95
test(artifacts): cover internal runtime failures
Abiorh001 1aaf356
test(artifacts): cover concurrent runtime initialization
Abiorh001 90bf971
docs(auth): record passing artifact coverage
Abiorh001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
...XINT-002-art-auth-end-to-end/reviews/WS-XINT-002-03-external-review-response.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # WS-XINT-002-03 External Review Response | ||
|
|
||
| ## Hosted Backend run 30284611419 | ||
|
|
||
| The semantic lanes executed but the independent evidence validator correctly | ||
| failed because `shared_foundations` contained three test failures. | ||
|
|
||
| - The missing-object put test now proves two prepared and two consumed | ||
| capabilities in exact `claim`, `terminal` order. | ||
| - The terminal-authority-drift double now permits claim consumption and denies | ||
| only terminal consumption, preserving the running retry fence and committing | ||
| no terminal facts. | ||
| - The custody parser accepts the exact active/current-availability table header | ||
| while retaining exact action-set and duplicate validation. | ||
|
|
||
| The focused isolated PostgreSQL rerun passed all four relevant regressions. | ||
| QA, test-delta, and CI-integrity re-reviews passed. No workflow, lane, | ||
| threshold, skip, or coverage policy changed. | ||
|
|
||
| ## CodeRabbit review | ||
|
|
||
| - Accepted the process-lifecycle finding. Celery child initialization now | ||
| claims and initializes one provider store, operations lease it against | ||
| shutdown, disabled storage skips initialization, and shutdown waits for | ||
| active leases. A concrete local bootstrap/store test prevents namespace | ||
| identity from crossing the lifecycle boundary. | ||
| - Accepted malformed selector normalization. Invalid UUID or prepared-scope | ||
| selectors now fail as `ArtifactAuthorityDeniedError` and have a focused test. | ||
| - Accepted the denial-contract finding. Both specifications now describe the | ||
| ART-only rollback-then-clean-restage exception, including still-planned exact | ||
| denials issuing no handle. | ||
| - The recovery terminal-denial finding was already repaired on the current | ||
| head with phase-aware claim/terminal behavior. | ||
| - The `${EMPTY}` split in the contract is required by the repository stale- | ||
| wording policy. Its shell assignment is now explicit, so the documented | ||
| coverage targets expand deterministically without reintroducing prohibited | ||
| wording. | ||
|
|
||
| Architecture, security, QA, and reuse/dedup focused re-reviews passed after the | ||
| repairs. Ruff, focused tests, stale checks, markdown links, and diff checks | ||
| passed. | ||
|
|
||
| ## Hosted Backend run 30287247882 | ||
|
|
||
| Three semantic lanes passed. The schema-contract lane exposed six existing | ||
| Alembic tests that still named migration `0036` as repository head after this | ||
| chunk added `0037`. Eight exact expected-revision values now name `0037`; all | ||
| schema, downgrade-refusal, row-preservation, and trigger assertions remain | ||
| unchanged. The same isolated six-test selection passed in 509.88 seconds, lane | ||
| inventory passed, and CI-integrity plus test-delta re-reviews passed. No CI or | ||
| coverage configuration changed. | ||
|
|
||
| ## CodeRabbit eager/non-prefork follow-up | ||
|
|
||
| Accepted. Resolver and verifier task bodies now idempotently initialize the | ||
| process runtime before leasing it, covering eager, solo, and thread execution | ||
| without weakening prefork startup. General `worker_shutdown` complements the | ||
| prefork child shutdown signal. The real Celery task bodies run under eager mode | ||
| in the focused regression; runtime, exact PREP action/context pairing, and | ||
| direct-require denial tests passed. Architecture, security, and QA focused | ||
| re-reviews passed. | ||
|
|
||
| ## Hosted Backend run 30290229205 | ||
|
|
||
| All semantic lanes, the independent evidence validator, combined coverage, | ||
| API end-to-end tests, and the full backend coverage gate passed. The remaining | ||
| artifact-foundation coverage gate correctly failed at 89.42 percent against | ||
| its unchanged 90 percent floor. | ||
|
|
||
| The repair adds branch coverage for process-runtime claim cleanup, unsupported | ||
| operation rejection, rollback-before-denial-restage ordering, pending-work scan | ||
| success and denial handling, invalid authority state, malformed pending-work | ||
| scope, unavailable service principals, and invalid principal identifiers. It | ||
| does not change workflow configuration, coverage targets, source inclusion, | ||
| test selection, or skip behavior. | ||
|
|
||
| Ruff, 18 focused unit tests, stale authorization and artifact-contract scans, | ||
| Markdown links, and diff integrity passed locally. QA and test-delta reviews | ||
| passed; the test-delta review specifically confirms the exact rollback then | ||
| restage assertion and found no weakening. The full PostgreSQL and exact-head | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| coverage proof remains assigned to GitHub Actions. | ||
|
|
||
| ## Hosted Backend run 30293817200 | ||
|
|
||
| Every non-coverage gate passed again. Artifact-foundation coverage rose to | ||
| 89.98 percent, leaving only the two unexecuted lines in the concurrent | ||
| process-runtime initializer branch. The final focused regression starts two | ||
| initializers at the same barrier, proves the losing bootstrap closes, and then | ||
| proves shutdown closes the installed winner. This directly covers the remaining | ||
| resource-leak safety branch; the focused test and all 14 verification tests | ||
| passed with Ruff and diff integrity. | ||
|
|
||
| ## Hosted Backend run 30294890075 | ||
|
|
||
| The exact-head rerun passed every Backend step. Artifact-foundation coverage is | ||
| 90.02 percent (4,689 statements, 468 missed), satisfying the unchanged 90 | ||
| percent floor; `internal_workers.py` is 100 percent covered. Agent Gates passed, | ||
| CodeRabbit is green, and no coverage or CI policy was weakened. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.