-
Notifications
You must be signed in to change notification settings - Fork 6
feat(auth): cut over project identity reads #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abiorh-claw
merged 8 commits into
main
from
codex/ws-auth-001-11b-project-identity-context
Jul 28, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
56e6298
feat(auth): cut over project identity reads
Abiorh001 3ab33ac
fix(auth): preserve read authorization boundaries
Abiorh001 751e235
fix(auth): address project context review
Abiorh001 18812e1
test(auth): order project role fixture inserts
Abiorh001 11ccdcc
test(auth): preserve reactivation attribution
Abiorh001 1f032db
ci(auth): preserve established coverage floors
Abiorh001 ee927dc
docs(auth): record final hosted evidence
Abiorh001 e027a9d
docs(projects): describe setup endpoints precisely
Abiorh001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
...tream-authorization-service/reviews/WS-AUTH-001-11B-internal-review-evidence.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # WS-AUTH-001-11B Internal Review Evidence | ||
|
|
||
| ## Scope | ||
|
|
||
| Project identity and self authorization-context hard cutover to current local | ||
| grants. Review covered the complete branch diff against the corrected 11B | ||
| contract. | ||
|
|
||
| ## Plan review | ||
|
|
||
| | Track | Result | Resolution | | ||
| |---|---|---| | ||
| | Architecture | PASS | AUTH owns the context projection; project and contributor response schemas remain distinct. | | ||
| | Security/auth | PASS | Exact actor/link revalidation, project scope, concealment, and route/action/evidence binding are explicit. | | ||
| | QA/test | PASS | Role matrix, denial cases, API controls, E2E, and focused project-read coverage are required. | | ||
| | Product/ops | PASS | Admin and contributor projections and role precedence are explicit. | | ||
| | Senior engineering | PASS | Exact manifests and the central decision/evidence path are explicit. | | ||
| | CI integrity | PASS WITH CONDITIONS | Preserve all existing lanes and floors; prove every new project-read branch without misrepresenting legacy project coverage. | | ||
|
|
||
| ## Implementation review | ||
|
|
||
| | Track | Final result | Findings resolved | | ||
| |---|---|---| | ||
| | Architecture | PASS WITH LOW RISKS | Missing-project decisions now use AUTH evidence; unrelated roles are filtered; project lifecycle projection shares the kernel guard. | | ||
| | Security/auth | PASS | Both reads use human/rate admission; decisions retain matched grant/project evidence; matched grants remain locked through projection. | | ||
| | QA/test | PASS WITH LOW RISKS | Added contributor, cross-project, revocation, suspension, link-revocation, rate, nonhuman, missing-project, and archived-project proof. | | ||
| | Product/ops | PASS | Context includes active AUTH-10B/10C/11B project actions and excludes planned 11C actions. | | ||
| | Senior engineering | PASS WITH LOW RISKS | Restored scope-specific denial evidence and public service exports. | | ||
| | CI integrity | PASS WITH LOW RISKS | No established gate weakening; hosted full-suite, global 78%, and actor/authorization 90% floors remain required. | | ||
|
|
||
| ## Local evidence | ||
|
|
||
| - `ruff check app tests scripts`: passed. | ||
| - Focused kernel, context projection, rate-admission, and nonhuman tests: passed. | ||
| - `tests/test_api_controls.py`: 27 passed. | ||
| - Catalogue activation test: passed. | ||
| - Python compile and docstring gate: passed. | ||
| - Stale wording, stale authorization docs, Markdown links, lightweight agent | ||
| gates, and `git diff --check`: passed. | ||
| - Hosted Backend run `30360376315` passed the database-backed route tests, four | ||
| semantic lanes, independent custody validation, API E2E, full-suite 78% | ||
| coverage floor, and every established subsystem coverage floor. | ||
|
|
||
| ## Residual review focus | ||
|
|
||
| The manual `_PROJECT_CONTEXT_ACTIONS` inventory must be updated by future | ||
| project-action activation chunks. A later catalogue metadata grouping may | ||
| replace it; no additional abstraction is required for 11B. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.