-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add support for Vaadin 25 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR upgrades the add-on from version 3.2.1-SNAPSHOT to 3.3.0-SNAPSHOT with Vaadin 25 compatibility support. It introduces version-aware JSON encoding via reflection-based MethodHandle resolution for ClientTerminalAddon, adds a json-migration-helper dependency, updates Lombok, replaces testbench dependencies, and establishes new integration test infrastructure for testing client-side terminal addons. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/test/java/com/flowingcode/vaadin/addons/xterm/integration/SampleClientTerminalAddonIT.java`:
- Around line 31-36: testSelectionFeature1 currently calls
$server.setSampleClientTerminalAddonValue(BAR) and immediately asserts
getSampleClientTerminalValue(term), which can race because
setSampleClientTerminalAddonValue is asynchronous; modify the test to wait for
the client-side addon value to appear before asserting (e.g., use a
TestBench/waitUntil or Awaitility loop that repeatedly calls
getSampleClientTerminalValue(term) until it equals BAR or a timeout is reached)
so the assertion only runs once the value is visible.



Close #104
Close #105
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.