Merged
Conversation
Distinguish between Classic Flang (PGI-derived) and LLVM Flang (flang-new) which use different compiler flags: - Classic Flang: -Mpreprocess (PGI-style) - LLVM Flang: -cpp (GCC-style) CMake 3.24+ identifies LLVM Flang as "LLVMFlang" while Classic Flang remains "Flang". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add CI testing with LLVM Flang (flang-new) versions 19 and 20: - New workflow uses official LLVM apt repository - Tests on Ubuntu 24.04 with cmake build - Add badge and update supported compilers table in README Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The rand/random functions were declared with pure interfaces but called impure intrinsic random_number(). This caused interface mismatch warnings with strict compilers like LLVM Flang. Rather than relaxing the pure requirement (which would affect all function pointers), remove rand support entirely to maintain purity guarantees for all mathematical functions. Changes: - Remove rand_function enumerator and reduce nFunctions to 16 - Remove randomize_r32/r64 interfaces and implementations - Remove rand32/rand64 functions - Remove 10 random test files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #45
This PR removes support for the
randfunction in strings passed to feq-parse. This is done so that pure elemental functions can continue to be used for functions that are supported by feq-parse. Longer term, we'll need to look into ways to support impure functions.This PR also adds a test for versions 19 and 20 of the LLVM Flang (in addition to amdflang) compilers.