Bluetooth support fix#2
Open
mooomooo wants to merge 2 commits into
Open
Conversation
| print("Searching for bt devices on OSX", file=log) | ||
| # on osx a rfcomm port is created and linked automatically when the cameo is connected | ||
| # TODO add support for other machines. I would expect files like CAMEO3-... and PORTRAIT2-... | ||
| pat = re.compile("tty\.(PORTRAIT2|CAMEO3|CAMEO4)-.*") |
Owner
There was a problem hiding this comment.
Are you sure about this? Normally I would expect the old code to match a dot character (".") whereas the new code would match any character but newlines?
We probably should use a raw string here, too. However, the current branch version using PyBluez does not have this problem anyways.
| else: # linux | ||
| print("Searching for bt devices on Linux", file=log) | ||
|
|
||
| pat = re.compile("tty\.(PORTRAIT2|CAMEO3|CAMEO4)-?.*") |
| self.draw_mm_cmd(bbox['ury'], bbox['llx'])] | ||
|
|
||
| # potentially long command string needs extra care | ||
| self.safe_send_command(cmd_list) |
Owner
There was a problem hiding this comment.
Yes I also stumbled over that one, but I think it only occurs if sending nothing to the device, no? If that were the case, this should probably be handled from the plugin itself, i.e. we should test directly when the extensions is launched, whether a object/path was currently selected.
But it probably doesn't hurt to catch it here also. Just saying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle some DeprecationWarnings when running on Inkscape 1.0, should negligibly impact behavior.