Fix FreeRDP 3.x compatibility #390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated /app: parameter syntax from v2 to v3 format - Changed /app:"executable" to /app:program:executable - Moved /app-cmd: parameter inside /app: as cmd: - Moved /app-icon: parameter inside /app: as icon: - Fixed installer.sh to use correct FreeRDP 3.x syntax - Tested on Fedora 42 with FreeRDP 3.21.0 This fixes compatibility for users on modern Linux distributions shipping FreeRDP 3.x (Fedora 40+, Ubuntu 24.10+, etc.) Fixes issues where winapps would fail with 'Unexpected keyword' or 'Command line parsing failed' errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes compatibility with FreeRDP 3.x, which introduced breaking changes to the
/app:parameter syntax. Without these changes, winapps fails on modern Linux distributions shipping FreeRDP 3.x.Changes Made
/app:parameter syntax inbin/winapps(6 locations)/app:parameter syntax ininstaller.sh(1 location)/app:"executable"to/app:program:executable/app-cmd:parameter inside/app:ascmd:/app-icon:parameter inside/app:asicon:Testing
bin/winapps checkworks correctlyAffected Systems
This fixes winapps for users on distributions shipping FreeRDP 3.x:
Error Messages Fixed
Command line parsing failed at 'app' value 'explorer.exe' [-1002]Unexpected keyworderrors during installation