Skip to content

Conversation

@arnaud-moncel
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Jan 26, 2026

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 5): add_datasource 1

@composite_datasource.add_data_source(datasource)
})

self
Copy link

@qltysh qltysh bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 5): add_datasource [qlty:function-complexity]

matthv
matthv previously approved these changes Jan 26, 2026
@arnaud-moncel arnaud-moncel merged commit fc9e129 into main Jan 26, 2026
35 checks passed
@arnaud-moncel arnaud-moncel deleted the feat/rpc-agent/add-markcollection-rpc-option branch January 26, 2026 15:47
forest-bot added a commit that referenced this pull request Jan 26, 2026
# [1.23.0](v1.22.3...v1.23.0) (2026-01-26)

### Features

* **rpc agent:** add mark collection as rpc option on add datasource ([#256](#256)) ([fc9e129](fc9e129))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants