[13.0][IMP] multicompany_property_*: allow records without company#110
Open
AdriaGForgeFlow wants to merge 3 commits into13.0from
Open
[13.0][IMP] multicompany_property_*: allow records without company#110AdriaGForgeFlow wants to merge 3 commits into13.0from
AdriaGForgeFlow wants to merge 3 commits into13.0from
Conversation
| <field | ||
| name="property_account_income_id" | ||
| domain="[('deprecated', '=', False),('company_id','=',company_id)]" | ||
| domain="[('deprecated', '=', False),'|', ('company_id','=',company_id), ('company_id','=',False)]" |
Contributor
There was a problem hiding this comment.
I wouldn't do the change for everything, I would do it regarding the default security rules or the company_id field in the model. For instance, for account.account company_id is required, so the change won't make sense here IMO.
Author
There was a problem hiding this comment.
Done 👍
I have kept the previous domain for all fields for which the related models have the company as a required field.
AdriaGForgeFlow
force-pushed
the
13.0-multicompany_property-allow_records_without_company_id
branch
from
543b473 to
027a01a
Compare
…hout company_id set
…cting values without company_id set
…es without company_id set
AdriaGForgeFlow
force-pushed
the
13.0-multicompany_property-allow_records_without_company_id
branch
from
027a01a to
ec466d1
Compare
Contributor
|
I don't understand first and third commit :S |
MiquelRForgeFlow
approved these changes
May 11, 2021
Contributor
probably they are "legacy" from previous changes, after corrections they can be dropped I think. |
Contributor
|
I think we can rebase and drop first and third commit directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the domain filters out all records for which the company is not the same as the company being edited but IMO records without company should be available for all companies.