[10.0 ENH] Purchase line extras#17
Open
richard-willdooit wants to merge 2 commits intoForgeFlow:10.0from
Open
Conversation
added 2 commits
November 13, 2017 09:36
Make order line company id computed and dependent so it defaults better for a new purchase order line. Also, ensure domains added to more views for alternate viewing and editing.
Codecov Report
@@ Coverage Diff @@
## 10.0 #17 +/- ##
==========================================
+ Coverage 52.57% 52.61% +0.03%
==========================================
Files 115 115
Lines 4854 4860 +6
==========================================
+ Hits 2552 2557 +5
- Misses 2302 2303 +1
Continue to review full report at Codecov.
|
|
|
||
| company_id = fields.Many2one( | ||
| 'res.company', related=[], compute='_compute_line_company', | ||
| string='Company', store=True, readonly=True) |
Contributor
There was a problem hiding this comment.
you shouldn't put the unchanged attributes
Author
There was a problem hiding this comment.
It is changed - it used to be related, it is now computed....
Contributor
There was a problem hiding this comment.
yeah, but you don't need to put again 'res.company', string, store, ...
MiquelRForgeFlow
force-pushed
the
10.0
branch
2 times, most recently
from
ef06178 to
e7d37d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make order line company id computed and dependent so it defaults
better for a new purchase order line.
Also, ensure domains added to more views for alternate viewing
and editing.