[10.0] [FIX] account.payment company_id is related#24
Open
richard-willdooit wants to merge 1 commit intoForgeFlow:10.0from
Open
[10.0] [FIX] account.payment company_id is related#24richard-willdooit wants to merge 1 commit intoForgeFlow:10.0from
richard-willdooit wants to merge 1 commit intoForgeFlow:10.0from
Conversation
Since company_id is related from journal_id, it makes no sense to use the company_id to restrict the journal!
thomaspaulb
reviewed
Jul 19, 2019
| # @api.onchange('create_company_id') | ||
| # def onchange_company_id(self): | ||
| # if self.create_company_id and self.journal_id.company_id != self.create_company_id: | ||
| # self.journal_id = False |
| return inv.company_id.id | ||
| return self.env.user.company_id.id | ||
|
|
||
| create_company_id = fields.Many2one('res.company', string='Company', default=_get_default_company) |
There was a problem hiding this comment.
Line 70 and 74 are >80 lines and so the linter complains and the PR is red
Contributor
There was a problem hiding this comment.
We're not actively maintaing the v10 branch. I believe that by now it must be quite obsolete.
v11 is up to date. I suggest that you consider reviewing that branch first.
There was a problem hiding this comment.
Unfortunately I have a customer on 10.0 who wants to use this :-)
I have realized 10.0 is behind, so am now testing 11.0 and considering the possibility of backporting some functionalities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since company_id is related from journal_id, it makes no sense to use
the company_id to restrict the journal!