[FIX 10.0] readonly company on account.move.line#33
Open
richard-willdooit wants to merge 1 commit intoForgeFlow:10.0from
Open
[FIX 10.0] readonly company on account.move.line#33richard-willdooit wants to merge 1 commit intoForgeFlow:10.0from
richard-willdooit wants to merge 1 commit intoForgeFlow:10.0from
Conversation
Account move line link to company_id (related from account.account) is not readonly in the base. Some writes are causing an unnecessary write to account.account on company_id (even though company_id is not changing), which causes the constraint validation - which is quite resource hungry given the large number of searches. Besides being an unnecessary overhead, it fails when this module has been installed on an existing database and there is history that was not aligned.
Codecov Report
@@ Coverage Diff @@
## 10.0 #33 +/- ##
==========================================
+ Coverage 52.58% 52.59% +<.01%
==========================================
Files 118 118
Lines 4931 4932 +1
==========================================
+ Hits 2593 2594 +1
Misses 2338 2338
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account move line link to company_id (related from account.account)
is not readonly in the base. Some writes are causing an unnecessary
write to account.account on company_id (even though company_id is
not changing), which causes the constraint validation - which is
quite resource hungry given the large number of searches.
Besides being an unnecessary overhead, it fails when this module
has been installed on an existing database and there is history
that was not aligned.