[18.0][FIX] rma_purchase: fix missing arguments in call to super#692
Open
StefanRijnhart wants to merge 1 commit into
Open
[18.0][FIX] rma_purchase: fix missing arguments in call to super#692StefanRijnhart wants to merge 1 commit into
StefanRijnhart wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 18.0 #692 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 130 130
Lines 5560 5560
Branches 702 702
=======================================
Hits 4415 4415
Misses 920 920
Partials 225 225
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On purchase orders with a non-default currency, currency conversion is wrong on new purchase order lines.
How to reproduce
Create a purchase order and set the currency to a non-default currency. Be sure to save the purchase order. Then click Add Product. You can see that the currency on the new line is already wrong, and is not taken from the line's purchase order.
Actual result
When a price is derived from a product supplierinfo (which has a specific currency) the rate conversion is not applied as expected.
Since 14.0! 9de5abc