chore: move-archived#107
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 289 files, which is 139 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (289)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cerebrl
reviewed
Apr 22, 2026
| @@ -54,7 +54,6 @@ | |||
| "*.{html,json}": "prettier --write" | |||
| }, | |||
| "dependencies": { | |||
| "@forgerock/davinci-client": "latest", | |||
| "@paralleldrive/cuid2": "^2.2.2" | |||
| "@forgerock/davinci-client": "latest" | |||
Contributor
There was a problem hiding this comment.
Is it intentional to just list DaVinci Client as a dependency?
Contributor
There was a problem hiding this comment.
I would say we can remove this. Sample apps that need davinci client should already have the dependency installed locally.
SteinGabriel
reviewed
May 5, 2026
ESLint resolves plugins from the config file's directory (javascript/), not workspace subdirectories, so the plugin must be hoisted via root.
webpack serve requires webpack-dev-server at runtime; without it webpack-cli prompts interactively and times out CI e2e tests.
ancheetah
reviewed
May 6, 2026
Comment on lines
9
to
15
| @@ -13,11 +13,11 @@ | |||
| "./Archived/central-login-oidc-client/", | |||
| "./Archived/reactjs-todo-journey-legacy/", | |||
| "./Archived/embedded-login/", | |||
Contributor
There was a problem hiding this comment.
Looks like Rodrigo has named this root archived folder archived (lower case) whereas you have called it Archived (capital A). Not sure if this will create a new folder...
Contributor
Author
There was a problem hiding this comment.
I just used the name that it was which originally Archived but i can switch it.
ancheetah
reviewed
May 7, 2026
Comment on lines
+9
to
+15
| "./archived/angular-todo/", | ||
| "./archived/angular-todo-davinci/", | ||
| "./archived/embedded-login-davinci/", | ||
| "./archived/central-login-oidc/", | ||
| "./archived/central-login-oidc-client/", | ||
| "./archived/reactjs-todo-journey-legacy/", | ||
| "./archived/embedded-login/", |
Contributor
There was a problem hiding this comment.
Think this needs to be .archived/javascript, right?
- Rename Archived/ to archived/ (lowercase) for consistency - Remove @forgerock/davinci-client from root dependencies - Fix CI.yml working-directory and e2e paths now that package.json is at root
ancheetah
approved these changes
May 7, 2026
cerebrl
approved these changes
May 7, 2026
SteinGabriel
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved archived directory to root.
https://pingidentity.atlassian.net/browse/SDKS-4975