Feature(trace-deps, trace-pkg): User conditions#12
Merged
ryan-roemer merged 10 commits intomainfrom Sep 10, 2022
Merged
Conversation
trace-deps] Feature: User conditions
trace-deps] Feature: User conditionstrace-deps Feature: User conditions
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 18 18
Lines 713 713
=======================================
Hits 705 705
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
trace-deps Feature: User conditions
ryan-roemer
commented
Sep 8, 2022
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| "trace-deps": minor | |||
| "trace-pkg": minor | |||
Member
Author
There was a problem hiding this comment.
Although this is minor for changesets, this is a 0.X release which allows breaking changes.
carbonrobot
approved these changes
Sep 9, 2022
carbonrobot
left a comment
There was a problem hiding this comment.
The plot thickens! So many edge cases
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds user
conditionsflag. We're following the https://github.com/vercel/nft#exports--imports model of always including some built-in Node.js conditions because the Node.js runtime actually does this (e.g., if I'm runningnode -C my-bespoke ./file.jsand there's animportcondition beforemy-bespokethe Node.js built-in matching meansimportwins).productionanddevelopmentuser conditions by default, but practically no one has code that is likely impacted..../cc @yankovalera